feat: removes npm/yarn lint from steps

[Toolo]

Description

We're running into a situation where parts of yarn lint end up running twice because they are both parth of pre-commit config and the package.json script.

Instead of duplicating, we're going to ensure all pre-commit hooks are executed via pre-commit (or pre-commit run --all-files for general operation).

Changes

• feat: removes npm/yarn lint from steps

🚀 PR created with fotingo

[github-actions]

Release notes preview

Below is a preview of the release notes if your PR gets merged.

---

6.0.0 (2024-02-29)

⚠ BREAKING CHANGES

• consumers will need to specify required tasks as pre-commit steps, instead of package.json scripts

Features

• removes npm/yarn lint from steps (6b421e6)

[github-actions]

Error: missing breaking changes documentation

This pull request contains breaking changes, but no documentation has been added to docs/breaking-changes/v6.md.

Instructions for creating breaking changes document:

mkdir -p docs/breaking-changes
cat <<EOF > docs/breaking-changes/v6.md
# Breaking changes in v6

[//]: # "Brief description of current major version release scope. (remove comment after updating)"

## Description of changes

[//]: # "Elaborate and add context to help the developer understand the changes. (remove comment after updating)"

## Upgrade instructions

[//]: # "Required and suggested prerequisites, example code, etc. (remove comment after updating)"

EOF

---

[tagoro9]

Just one question + missing breaking changes docs

[tagoro9]

Wouldn't we need to still install dependencies so that pre-commit hooks like eslint work?

[armand-sauzay]

We wanted to do something similar for open-turo/actions-python, looks like the leanest/fastest approach would be to run something along the lines of:

jobs:
  lint:
    name: Lint
    runs-on: [self-hosted, general-ubuntu]
    steps:
      - name: Checkout
        uses: actions/checkout@v4
        with:
          fetch-depth: 0
      - name: Setup python
        uses: actions/setup-python@v5 #or open-turo/action-setup-tools but action-setup-tools is quite slow for new version that are not pre-installed on the runners while the open source ones are caching everything and very fast
      - name: Install pre-commit
        run: pip install pre-commit
      - name: Run pre-commit
        run: pre-commit run --show-diff-on-failure --color=always --all-files

we could also do caching on the pre-commit dependencies but I guess that's another level of optimization. It already runs in 10s-1minute with the above approach (vs 2-4minutes when installing dependencies)