Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update Default Port from 8002 to 8080 on CLI Options #3012

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tcortega
Copy link

Based on analysis of documentation and code related to wa-automate, it was determined that there is no need for the default port to be set to 8002. This pull request updates the default port to 8080 to prevent confusion in the future.

@smashah
Copy link
Member

smashah commented Jan 13, 2023

Thanks for the PR.

The reason it's something random like 8002 is because maybe some other service is using 8080 and to prevent future issues of "oh why isn't this thing starting??".

If the documentation is confusing then that should be changed instead.

If this change is to be merged then it will need to take place on a major version

@tcortega
Copy link
Author

Thanks for the PR.

The reason it's something random like 8002 is because maybe some other service is using 8080 and to prevent future issues of "oh why isn't this thing starting??".

If the documentation is confusing then that should be changed instead.

If this change is to be merged then it will need to take place on a major version

I guess we should change the documentation around it then. Most of the documentations regarding wa-automate, the EasyAPI and the Socket mode really mentions the default port being 8080.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants