-
Notifications
You must be signed in to change notification settings - Fork 566
MW-213 Discover and implement kotlin docs and generate documentation #1861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from 1 commit
114ae9b
27518ad
d23b76b
7b524a7
93415f6
3607573
7c8fdad
abd4782
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,7 @@ | |
| plugins { | ||
| alias(libs.plugins.mifospay.cmp.feature) | ||
| alias(libs.plugins.kotlin.parcelize) | ||
| alias(libs.plugins.dokka) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove these plugins |
||
| } | ||
|
|
||
| android { | ||
|
|
@@ -27,4 +28,23 @@ kotlin { | |
| implementation(libs.kotlinx.serialization.json) | ||
| } | ||
| } | ||
| } | ||
| // Configure Dokka | ||
| tasks.withType<org.jetbrains.dokka.gradle.DokkaTask>().configureEach { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be be part of feature and library gradle custom plugin
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move these in feature and library build-logic gradle plugin |
||
| // Output format (HTML by default) | ||
| outputDirectory.set(layout.buildDirectory.dir("dokka")) | ||
|
|
||
| // Module name in documentation | ||
| moduleName.set("feature") | ||
|
|
||
| // Documentation format | ||
| dokkaSourceSets { | ||
| configureEach { | ||
| sourceLink { | ||
| localDirectory.set(file("src")) | ||
| remoteUrl.set(uri("https://github.com/openMF/mobile-wallet.git").toURL()) | ||
| remoteLineSuffix.set("#L") | ||
| } | ||
| } | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,7 @@ plugins { | |
| alias(libs.plugins.mifospay.cmp.feature) | ||
| alias(libs.plugins.kotlin.parcelize) | ||
| alias(libs.plugins.kotlin.serialization) | ||
| alias(libs.plugins.dokka) | ||
| } | ||
|
|
||
| android { | ||
|
|
@@ -44,4 +45,23 @@ kotlin { | |
| implementation(libs.play.services.auth) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| tasks.withType<org.jetbrains.dokka.gradle.DokkaTask>().configureEach { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above, it should be moved in feature and library gradle plugin
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move the Dokka configurations into the root |
||
| // Output format (HTML by default) | ||
| outputDirectory.set(layout.buildDirectory.dir("dokka")) | ||
|
|
||
| // Module name in documentation | ||
| moduleName.set("feature") | ||
|
|
||
| // Documentation format | ||
| dokkaSourceSets { | ||
| configureEach { | ||
| sourceLink { | ||
| localDirectory.set(file("src")) | ||
| remoteUrl.set(uri("https://github.com/openMF/mobile-wallet.git").toURL()) | ||
| remoteLineSuffix.set("#L") | ||
| } | ||
| } | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ org.gradle.configureondemand=false | |
| org.gradle.caching=true | ||
|
|
||
| # Enable configuration caching between builds. | ||
| org.gradle.configuration-cache=true | ||
| org.gradle.configuration-cache=false | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Revert it back
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's enable configuration caching to improve build performance. While it may occasionally fail due to cache mismatches, running clean and rebuilding typically resolves the issue. Disabling it would significantly slow down our builds, so the trade-off is worth it.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok |
||
| # This option is set because of https://github.com/google/play-services-plugins/issues/246 | ||
| # to generate the Configuration Cache regardless of incompatible tasks. | ||
| # See https://github.com/android/nowinandroid/issues/1022 before using it. | ||
|
|
@@ -53,4 +53,5 @@ RblClientIdProp=a | |
| RblClientSecretProp=b | ||
|
|
||
| kotlin.native.ignoreDisabledTargets=true | ||
| kotlin.mpp.androidGradlePluginCompatibility.nowarn=true | ||
| kotlin.mpp.androidGradlePluginCompatibility.nowarn=true | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -366,3 +366,4 @@ ktlint = { id = "org.jlleitschuh.gradle.ktlint", version.ref = "ktlint" } | |
| spotless = { id = "com.diffplug.spotless", version.ref = "spotlessVersion" } | ||
| version-catalog-linter = { id = "io.github.pemistahl.version-catalog-linter", version.ref = "versionCatalogLinterVersion" } | ||
|
|
||
| dokka = { id = "org.jetbrains.dokka", version = "2.0.0" } | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. use a variable for version number of this library like above libraries instead of hardcoding
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. use the variable Please don't resolve the conversion even though you fixed it. |
||
Uh oh!
There was an error while loading. Please reload this page.