Skip to content

feat(settings): Fix settings to use savings accountId for disabling accounts #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IITI-tushar wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat(settings): Fix settings to use savings accountId for disabling accounts #2014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions feature/settings/src/commonMain/kotlin/org/mifospay/feature/settings/SettingsViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,13 +225,20 @@ class SettingsViewModel(
}

private fun handleDisableAccount() {
val accountId = userPreferencesRepository.defaultAccountId.value
if (accountId == null) {
mutableStateFlow.update {
it.copy(dialogState = DialogState.Error("Default account not available"))

@coderabbitai coderabbitai Bot May 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Replace hardcoded error text with a string resource.

"Default account not available" is user-facing and currently hardcoded, while this ViewModel otherwise uses localized Res.string.*/getString(...) messages. Please move this to resources for i18n consistency.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@feature/settings/src/commonMain/kotlin/org/mifospay/feature/settings/SettingsViewModel.kt`
at line 231, The hardcoded user-facing message in SettingsViewModel (the
expression it.copy(dialogState = DialogState.Error("Default account not
available"))) should be replaced with the localized string resource used
elsewhere (e.g., Res.string.* or the existing getString(...) helper); update the
DialogState.Error call to pass the resource-backed string (fetching the
appropriate "default_account_not_available" resource) so the ViewModel uses
i18n-consistent messaging.

}
return
}

mutableStateFlow.update {
it.copy(dialogState = DialogState.Loading)
}

// TODO:: this shouldn't work, we need account id to block account
viewModelScope.launch {
val result = repository.blockAccount(state.client.id)
val result = repository.blockAccount(accountId)
sendAction(DisableAccountResult(result))
}
}
Expand Down
Loading