Removed back button on "Add Clients" page to prevent 404 errors #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Craig-Rosario I agree the back button looked quite weird, but do we need to remove it? Should it be fixed instead and by clicking on it it should navigate to the page of "test2" group? |
|
Hi, @adamsaghy The main reasons why I chose to remove the back button altogether is because, The layout and styling of it isn't suitable and breadcrumbs already do the same job. Or should I open another issue/update this PR, which fixes the layout and also relinks to test2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed Back button on "Add Clients", which is broken and leads to a 404 page
Related issues and discussion
Fixes WEB-48
https://mifosforge.jira.com/browse/WEB-48
Screenshots, if any
Before:
After:
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.