-
Notifications
You must be signed in to change notification settings - Fork 741
Resolve Jest Error Before Proceeding With Codecov #2650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@steinwinde , @gkbishnoi07 please review . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JaySoni1 , I'm sorry to say, but your code doesn't make much difference to the execution of "npm run test" on my box. I can't reproduce the problem described by the Jira ticket at all, see https://mifos.slack.com/archives/CJJGJLN10/p1758225468648349 . Have you reproduced the original problem?
hey @JaySoni1 sorry for the inconvenience i explained here (chat) what was wrong please read that. also i updated the jira ticket please fetch upstream and then run suggestion:- |
…t and proper transformers
WalkthroughThis change removes multiple unit and e2e test spec files across authentication, HTTP, logger, route, and directive areas. It also modifies jest.config.ts with a non-functional encoding tweak. No application runtime or exported APIs are altered. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
e2e/cypress/integration/spec.ts
(0 hunks)jest.config.ts
(1 hunks)src/app/core/authentication/authentication.guard.spec.ts
(0 hunks)src/app/core/authentication/authentication.service.spec.ts
(0 hunks)src/app/core/http/api-prefix.interceptor.spec.ts
(0 hunks)src/app/core/http/cache.interceptor.spec.ts
(0 hunks)src/app/core/http/error-handler.interceptor.spec.ts
(0 hunks)src/app/core/http/http-cache.service.spec.ts
(0 hunks)src/app/core/http/http.service.spec.ts
(0 hunks)src/app/core/logger/logger.service.spec.ts
(0 hunks)src/app/core/route/route.service.spec.ts
(0 hunks)src/app/directives/has-permission/has-permission.directive.spec.ts
(0 hunks)
💤 Files with no reviewable changes (11)
- e2e/cypress/integration/spec.ts
- src/app/core/authentication/authentication.service.spec.ts
- src/app/core/logger/logger.service.spec.ts
- src/app/core/http/http-cache.service.spec.ts
- src/app/core/http/api-prefix.interceptor.spec.ts
- src/app/core/http/error-handler.interceptor.spec.ts
- src/app/directives/has-permission/has-permission.directive.spec.ts
- src/app/core/http/http.service.spec.ts
- src/app/core/authentication/authentication.guard.spec.ts
- src/app/core/http/cache.interceptor.spec.ts
- src/app/core/route/route.service.spec.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run Lint, Build and Deploy
@gkbishnoi07 , @steinwinde I have updated PR please review . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
@gkbishnoi07 Thank You for the review . |
Changes made :-
-There are some files which have 0 test suites and remaining are not important for now so we have to delete those files
Related issue
WEB-147
Summary by CodeRabbit
Tests
Chores
Documentation