Allow a datetime string to be provided for a property with type "date" #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raphael-Gazzotti
approved these changes
Oct 21, 2025
Raphael-Gazzotti
merged commit 29ca99f
into
openMetadataInitiative:pipeline
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to be more forgiving when handling JSON-LD documents generated by other tools.
Specifically, if the document contains a datetime string, such as "2024-02-07T00:00:00" where openMINDS expects a date (like "2024-02-07"), we should accept that.
A stricter version of this would be to only accept strings where the hour-minute-second fields are all zero, but the current implementation just throws away the time information.