Fix nullpointer issue

openPMD · Jan 31, 2024 · 0ee77a2 · 0ee77a2
1 parent 67842ca
commit 0ee77a2
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/include/openPMD/snapshots/ContainerImpls.hpp b/include/openPMD/snapshots/ContainerImpls.hpp
@@ -20,7 +20,7 @@ class StatefulSnapshotsContainer : public AbstractSnapshotsContainer
     auto get() const -> StatefulIterator const *;
 
 public:
-    using AbstractSnapshotsContainer::currentIteration;
+    auto currentIteration() -> std::optional<value_type *> override;
     auto currentIteration() const -> std::optional<value_type const *> override;
 
     auto begin() -> iterator override;

diff --git a/src/snapshots/ContainerImpls.cpp b/src/snapshots/ContainerImpls.cpp
@@ -39,10 +39,29 @@ auto StatefulSnapshotsContainer::get() const -> StatefulIterator const *
 {
     return m_bufferedIterator.value_or(nullptr);
 }
+auto StatefulSnapshotsContainer::currentIteration()
+    -> std::optional<value_type *>
+{
+    if (auto it = get(); it)
+    {
+        return it->peekCurrentlyOpenIteration();
+    }
+    else
+    {
+        return nullptr;
+    }
+}
 auto StatefulSnapshotsContainer::currentIteration() const
     -> std::optional<value_type const *>
 {
-    return get()->peekCurrentlyOpenIteration();
+    if (auto it = get(); it)
+    {
+        return it->peekCurrentlyOpenIteration();
+    }
+    else
+    {
+        return nullptr;
+    }
 }
 auto StatefulSnapshotsContainer::begin() -> iterator
 {
@@ -93,7 +112,8 @@ auto StatefulSnapshotsContainer::rend() const -> const_iterator
 
 bool StatefulSnapshotsContainer::empty() const
 {
-    return get()->operator bool();
+    auto it = get();
+    return (!it) || it->operator bool();
 }
 
 auto StatefulSnapshotsContainer::at(key_type const &) const