Apply suggestions from code review

openPMD · Jul 17, 2023 · c001757 · c001757
1 parent eba5598
commit c001757
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/src/binding/python/Container.cpp b/src/binding/python/Container.cpp
@@ -24,7 +24,6 @@
  * BSD-style license, see pybind11 LICENSE file.
  */
 
-#include <cstddef>
 #include <pybind11/pybind11.h>
 #include <pybind11/stl.h>
 #include <pybind11/stl_bind.h>
@@ -42,6 +41,7 @@
 #include "openPMD/backend/PatchRecord.hpp"
 #include "openPMD/backend/PatchRecordComponent.hpp"
 
+#include <cstddef>
 #include <memory>
 #include <sstream>
 #include <string>
@@ -114,7 +114,7 @@ bind_container(py::handle scope, std::string const &name, Args &&...args)
             stream << num_entries << " entries and ";
         }
 
-        stream << m.numAttributes() << " attribute(s).>";
+        stream << m.numAttributes() << " attribute(s)>";
         return stream.str();
     });
 

diff --git a/src/binding/python/Dataset.cpp b/src/binding/python/Dataset.cpp
@@ -61,7 +61,7 @@ void init_Dataset(py::module &m)
             [](const Dataset &d) {
                 std::stringstream stream;
                 stream << "<openPMD.Dataset of type '" << d.dtype
-                       << " and with extent ";
+                       << "' and with extent ";
                 if (d.extent.empty())
                 {
                     stream << "[]>";

diff --git a/src/binding/python/Iteration.cpp b/src/binding/python/Iteration.cpp
@@ -41,7 +41,7 @@ void init_Iteration(py::module &m)
                 std::stringstream ss;
                 ss << "<openPMD.Iteration at t = '" << std::scientific
                    << it.template time<double>() * it.timeUnitSI()
-                   << " s' with  " << std::to_string(it.numAttributes())
+                   << " s' with " << std::to_string(it.numAttributes())
                    << " attributes>";
                 return ss.str();
             })

diff --git a/src/binding/python/MeshRecordComponent.cpp b/src/binding/python/MeshRecordComponent.cpp
@@ -41,7 +41,7 @@ void init_MeshRecordComponent(py::module &m)
           [](RecordComponent const &rc) {
               std::stringstream stream;
               stream << "<openPMD.Record_Component of type '"
-                     << rc.getDatatype() << " and with extent ";
+                     << rc.getDatatype() << "' and with extent ";
               if (auto extent = rc.getExtent(); extent.empty())
               {
                   stream << "[]>";

diff --git a/src/binding/python/PatchRecordComponent.cpp b/src/binding/python/PatchRecordComponent.cpp
@@ -57,7 +57,7 @@ void init_PatchRecordComponent(py::module &m)
             [](PatchRecordComponent const &rc) {
                 std::stringstream stream;
                 stream << "<openPMD.Patch_Record_Component of type '"
-                       << rc.getDatatype() << " and with extent ";
+                       << rc.getDatatype() << "' and with extent ";
                 if (auto extent = rc.getExtent(); extent.empty())
                 {
                     stream << "[]>";

diff --git a/src/binding/python/RecordComponent.cpp b/src/binding/python/RecordComponent.cpp
@@ -768,7 +768,7 @@ void init_RecordComponent(py::module &m)
           [](RecordComponent const &rc) {
               std::stringstream stream;
               stream << "<openPMD.Record_Component of type '"
-                     << rc.getDatatype() << " and with extent ";
+                     << rc.getDatatype() << "' and with extent ";
               if (auto extent = rc.getExtent(); extent.empty())
               {
                   stream << "[]>";