Don't require unitSI when reading patch record component (#1470)

openPMD · Jun 30, 2023 · c09d9bc · c09d9bc
1 parent 32aa2cb
commit c09d9bc
Showing 1 changed file with 19 additions and 17 deletions.
diff --git a/src/backend/PatchRecordComponent.cpp b/src/backend/PatchRecordComponent.cpp
@@ -143,24 +143,26 @@ void PatchRecordComponent::flush(
 
 void PatchRecordComponent::read()
 {
-    Parameter<Operation::READ_ATT> aRead;
-
-    aRead.name = "unitSI";
-    IOHandler()->enqueue(IOTask(this, aRead));
-    IOHandler()->flush(internal::defaultFlushParams);
-    if (auto val = Attribute(*aRead.resource).getOptional<double>();
-        val.has_value())
-        setUnitSI(val.value());
-    else
-        throw error::ReadError(
-            error::AffectedObject::Attribute,
-            error::Reason::UnexpectedContent,
-            {},
-            "Unexpected Attribute datatype for 'unitSI' (expected double, "
-            "found " +
-                datatypeToString(Attribute(*aRead.resource).dtype) + ")");
-
     readAttributes(ReadMode::FullyReread); // this will set dirty() = false
+
+    if (containsAttribute("unitSI"))
+    {
+        if (auto val = getAttribute("unitSI").getOptional<double>();
+            val.has_value())
+        {
+            setUnitSI(val.value());
+        }
+        else
+        {
+            throw error::ReadError(
+                error::AffectedObject::Attribute,
+                error::Reason::UnexpectedContent,
+                {},
+                "Unexpected Attribute datatype for 'unitSI' (expected double, "
+                "found " +
+                    datatypeToString(getAttribute("unitSI").dtype) + ")");
+        }
+    }
 }
 
 bool PatchRecordComponent::dirtyRecursive() const