Accept undefined dataset as long as no chunks are written yet

Just ignore and skip the component in that case
openPMD · Apr 12, 2023 · c38c82a · c38c82a
1 parent 0723a59
commit c38c82a
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 7 deletions.
diff --git a/src/RecordComponent.cpp b/src/RecordComponent.cpp
@@ -242,9 +242,21 @@ void RecordComponent::flush(
          */
         if (!rc.m_dataset.has_value())
         {
-            throw error::WrongAPIUsage(
-                "[RecordComponent] Must specify dataset type and extent before "
-                "flushing (see RecordComponent::resetDataset()).");
+            // The check for !written() is technically not needed, just
+            // defensive programming against internal bugs that go on us.
+            if (!written() && rc.m_chunks.empty())
+            {
+                // No data written yet, just accessed the object so far without
+                // doing anything
+                // Just do nothing and skip this record component.
+                return;
+            }
+            else
+            {
+                throw error::WrongAPIUsage(
+                    "[RecordComponent] Must specify dataset type and extent "
+                    "before flushing (see RecordComponent::resetDataset()).");
+            }
         }
         if (!written())
         {

diff --git a/src/backend/PatchRecordComponent.cpp b/src/backend/PatchRecordComponent.cpp
@@ -104,10 +104,22 @@ void PatchRecordComponent::flush(
     {
         if (!rc.m_dataset.has_value())
         {
-            throw error::WrongAPIUsage(
-                "[PatchRecordComponent] Must specify dataset type and extent "
-                "before "
-                "flushing (see RecordComponent::resetDataset()).");
+            // The check for !written() is technically not needed, just
+            // defensive programming against internal bugs that go on us.
+            if (!written() && rc.m_chunks.empty())
+            {
+                // No data written yet, just accessed the object so far without
+                // doing anything
+                // Just do nothing and skip this record component.
+                return;
+            }
+            else
+            {
+                throw error::WrongAPIUsage(
+                    "[PatchRecordComponent] Must specify dataset type and "
+                    "extent before flushing (see "
+                    "RecordComponent::resetDataset()).");
+            }
         }
         if (!written())
         {