Don't safeguard empty strings while reading #1223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
reviewed
Mar 13, 2022
| enum class SetAttributeMode : char | ||
| { | ||
| WhileReadingAttributes, | ||
| FromPublicAPICall |
Member
There was a problem hiding this comment.
Is that public API call both read and write? Might need a doxygen string, even though its readable already :)
Contributor
Author
There was a problem hiding this comment.
It's write-only in the public API, but during parsing, we emulate read_write mode and use setAttribute also internally
ax3l
reviewed
Mar 14, 2022
| key, value, internal::SetAttributeMode::FromPublicAPICall); | ||
| } | ||
|
|
||
| // TODO explicitly instantiate Attributable::setAttribute for all T in Datatype |
Member
There was a problem hiding this comment.
This is done in src/backend/Attributable.cpp
Suggested change
| // TODO explicitly instantiate Attributable::setAttribute for all T in Datatype | |
| // note: we explicitly instantiate Attributable::setAttributeImpl for all T in Datatype in Attributable.cpp |
Member
|
Will fix merge conflict from the merge of #1226 |
ax3l
force-pushed
the
workaround-no-safeguard-while-reading
branch
from
b0cfdcd to
1be5918
Compare
ax3l
reviewed
Mar 14, 2022
ax3l
approved these changes
Mar 14, 2022
Member
|
I have trouble backporting this to the |
Member
|
Applied to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround/fix for #1221