Skip to content

CI: No Need for Warn Deprecations #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ax3l merged 1 commit into from
May 2, 2022
Merged

CI: No Need for Warn Deprecations #1246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/intel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
run: |
sudo .github/workflows/dependencies/install_icc
- name: Build
env: {CXXFLAGS: -Werror -Wno-deprecated-declarations}
env: {CXXFLAGS: -Werror}
run: |
set +e; source /opt/intel/oneapi/setvars.sh; set -e
share/openPMD/download_samples.sh build
Expand All @@ -40,7 +40,7 @@ jobs:
run: |
sudo .github/workflows/dependencies/install_icx
- name: Build
env: {CXXFLAGS: -Werror -Wno-deprecated-declarations}
env: {CXXFLAGS: -Werror}
run: |
set +e; source /opt/intel/oneapi/setvars.sh; set -e
share/openPMD/download_samples.sh build
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
sudo apt-get install clang-6.0 libc++-dev libc++abi-dev
sudo .github/workflows/dependencies/install_spack
- name: Build
env: {CC: clang-6.0, CXX: clang++-6.0, CXXFLAGS: -stdlib=libc++ -Werror -Wno-deprecated-declarations -Wno-ignored-attributes -Wno-unused-const-variable}
env: {CC: clang-6.0, CXX: clang++-6.0, CXXFLAGS: -stdlib=libc++ -Werror -Wno-ignored-attributes -Wno-unused-const-variable}
# -Wno-ignored-attributes -Wno-unused-const-variable: clang-6 has a
# false positive on src/auxiliary/Filesystem.cpp
# [[maybe_unused]] MPI_Datatype const MPI_Types< unsigned >::value = MPI_UNSIGNED;
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
sudo apt-get install clang-6.0 libc++-dev libc++abi-dev gfortran libopenmpi-dev python3
sudo .github/workflows/dependencies/install_spack
- name: Build
env: {CC: clang-6.0, CXX: clang++-6.0, CXXFLAGS: -stdlib=libc++ -Werror -Wno-deprecated-declarations -Wno-ignored-attributes -Wno-unused-const-variable}
env: {CC: clang-6.0, CXX: clang++-6.0, CXXFLAGS: -stdlib=libc++ -Werror -Wno-ignored-attributes -Wno-unused-const-variable}
# -Wno-ignored-attributes -Wno-unused-const-variable: clang-6 has a
# false positive on src/auxiliary/Filesystem.cpp
# [[maybe_unused]] MPI_Datatype const MPI_Types< unsigned >::value = MPI_UNSIGNED;
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
sudo apt-get install clang-7 gfortran libopenmpi-dev python3
sudo .github/workflows/dependencies/install_spack
- name: Build
env: {CC: clang-7, CXX: clang++-7, CXXFLAGS: -Werror -Wno-deprecated-declarations, OPENPMD2_ADIOS2_SCHEMA: 20210209}
env: {CC: clang-7, CXX: clang++-7, CXXFLAGS: -Werror, OPENPMD2_ADIOS2_SCHEMA: 20210209}
run: |
eval $(spack env activate --sh .github/ci/spack-envs/clang7_nopy_ompi_h5_ad1_ad2/)
spack install
Expand Down Expand Up @@ -133,7 +133,7 @@ jobs:
sudo apt-get install clang-12 libhdf5-dev python3 python3-pip python3-numpy python3-pandas
sudo .github/workflows/dependencies/install_spack
- name: Build
env: {CC: clang-12, CXX: clang++-12, CXXFLAGS: -Werror -Wno-deprecated-declarations}
env: {CC: clang-12, CXX: clang++-12, CXXFLAGS: -Werror}
run: |
eval $(spack env activate --sh .github/ci/spack-envs/clang12_py38_nompi_h5_ad1_ad2/)
spack install
Expand Down Expand Up @@ -165,7 +165,7 @@ jobs:
sudo apt-get install clang-8 gfortran libmpich-dev python3
sudo .github/workflows/dependencies/install_spack
- name: Build
env: {CC: clang-8, CXX: clang++-8, CXXFLAGS: -Werror -Wno-deprecated-declarations, OPENPMD2_ADIOS2_SCHEMA: 20210209}
env: {CC: clang-8, CXX: clang++-8, CXXFLAGS: -Werror, OPENPMD2_ADIOS2_SCHEMA: 20210209}
run: |
cmake --version
mpiexec --version
Expand Down Expand Up @@ -221,7 +221,7 @@ jobs:
python3 -m pip install -U dask
python3 -m pip install -U pyarrow
- name: Build
env: {CC: gcc-7, CXX: g++-7, CXXFLAGS: -Werror -Wno-deprecated-declarations}
env: {CC: gcc-7, CXX: g++-7, CXXFLAGS: -Werror}
run: |
eval $(spack env activate --sh .github/ci/spack-envs/gcc7_py36_ompi_h5_ad1_ad2/)
spack install
Expand Down Expand Up @@ -249,7 +249,7 @@ jobs:
sudo apt-get install g++ libopenmpi-dev libhdf5-openmpi-dev libadios-dev python3 python3-numpy python3-mpi4py python3-pandas
# TODO ADIOS1 (.pc file broken?) ADIOS2
- name: Build
env: {CXXFLAGS: -Werror -Wno-deprecated-declarations, PKG_CONFIG_PATH: /usr/lib/x86_64-linux-gnu/pkgconfig}
env: {CXXFLAGS: -Werror, PKG_CONFIG_PATH: /usr/lib/x86_64-linux-gnu/pkgconfig}
run: |
share/openPMD/download_samples.sh build
chmod u-w build/samples/git-sample/*.h5
Expand All @@ -274,7 +274,7 @@ jobs:
apk add hdf5-dev
python3.10 -m pip install numpy
- name: Build
env: {CXXFLAGS: -Werror -Wno-deprecated-declarations}
env: {CXXFLAGS: -Werror}
run: |
share/openPMD/download_samples.sh build
chmod u-w build/samples/git-sample/*.h5
Expand Down Expand Up @@ -307,7 +307,7 @@ jobs:
mamba env create --file conda.yml
- name: Build
shell: bash -eo pipefail -l {0}
env: {CXXFLAGS: -Werror -Wno-deprecated-declarations}
env: {CXXFLAGS: -Werror}
run: |
source activate openpmd-api-dev

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
brew install python || true
set -e
- name: Build
env: {CXXFLAGS: -Werror -Wno-deprecated-declarations -DTOML11_DISABLE_STD_FILESYSTEM, MACOSX_DEPLOYMENT_TARGET: 10.13}
env: {CXXFLAGS: -Werror -DTOML11_DISABLE_STD_FILESYSTEM, MACOSX_DEPLOYMENT_TARGET: 10.13}
# C++11 & 14 support in macOS 10.9+
# C++17 support in macOS 10.13+/10.14+
# https://cibuildwheel.readthedocs.io/en/stable/cpp_standards/#macos-and-deployment-target-versions
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nvidia.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
name: [email protected]
runs-on: ubuntu-20.04
if: github.event.pull_request.draft == false
env: {CXX: nvcc, CXXFLAGS: "--forward-unknown-to-host-compiler -Xcompiler -Werror -Wno-deprecated-declarations"}
env: {CXX: nvcc, CXXFLAGS: "--forward-unknown-to-host-compiler -Xcompiler -Werror"}
steps:
- uses: actions/checkout@v2
- name: Dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tooling.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
sudo apt-get install clang clang-tidy gfortran libopenmpi-dev python
sudo .github/workflows/dependencies/install_spack
- name: Build
env: {CC: clang, CXX: clang++, CXXFLAGS: -Wno-deprecated-declarations}
env: {CC: clang, CXX: clang++}
run: |
eval $(spack env activate --sh .github/ci/spack-envs/clangtidy_nopy_ompi_h5_ad1_ad2/)
spack install
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
python3 -m pip install -U numpy
sudo .github/workflows/dependencies/install_spack
- name: Build
env: {CC: mpicc, CXX: mpic++, OMPI_CC: clang-10, OMPI_CXX: clang++-10, CXXFLAGS: -Werror -Wno-deprecated-declarations, OPENPMD_HDF5_CHUNKS: none, OPENPMD_TEST_NFILES_MAX: 100}
env: {CC: mpicc, CXX: mpic++, OMPI_CC: clang-10, OMPI_CXX: clang++-10, CXXFLAGS: -Werror, OPENPMD_HDF5_CHUNKS: none, OPENPMD_TEST_NFILES_MAX: 100}
run: |
eval $(spack env activate --sh .github/ci/spack-envs/clangtidy_nopy_ompi_h5_ad1_ad2/)
spack install
Expand Down