Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Hierarchies #1432

Open
wants to merge 25 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
9548c6c
Introduce SharedAttributableData
franzpoeschel Jun 28, 2023
3778d86
JSON backend: Fail when trying to open non-existing groups
franzpoeschel May 30, 2023
9bc40b5
Insert CustomHierarchy class to Iteration
franzpoeschel Apr 12, 2023
ee05935
Help older compilers deal with this
franzpoeschel May 25, 2023
aa4c13d
Add vector variants of meshes/particlesPath
franzpoeschel Jul 28, 2023
bbe8f56
Move meshes and particles over to CustomHierarchies class
franzpoeschel Jul 28, 2023
046d5ed
Move dirtyRecursive to CustomHierarchy
franzpoeschel May 30, 2023
d48dd1f
Move Iteration reading logic to CustomHierarchy
franzpoeschel Jul 28, 2023
67f31ba
Move Iteration flushing logic to CustomHierarchy class
franzpoeschel Jul 31, 2023
5e5a70a
Support for custom datasets
franzpoeschel Jul 31, 2023
3f97067
Treat "meshes"/"particles" as normal subgroups
franzpoeschel Jul 31, 2023
4fb107e
Regex-based list of meshes/particlesPaths
franzpoeschel Jul 31, 2023
d59def6
More extended testing
franzpoeschel Jul 31, 2023
2b1072e
Fix Python bindings without adding new functionality yet
franzpoeschel Aug 1, 2023
d44fec1
Add simple Python bindings and an example
franzpoeschel Aug 1, 2023
2d096f2
Replace Regexes with Globbing
franzpoeschel Oct 13, 2023
9018f82
Move .meshes and .particles back to Iteration class
franzpoeschel Oct 24, 2023
72fc6a9
Some fixes in read error handling
franzpoeschel Oct 26, 2023
c87f192
More symmetric design for container types
franzpoeschel Oct 26, 2023
2de3bc9
Don't write unitSI in custom datasets
franzpoeschel Nov 13, 2023
0b9cc3c
Discouraged support for custom datasets inside the particlesPath
franzpoeschel Dec 21, 2023
0c71945
Fix after rebase: dirtyRecursive
franzpoeschel Mar 26, 2024
c5d9b8b
Fixes to the dirty/dirtyRecursive logic
franzpoeschel May 24, 2024
e1c6fd1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 7, 2024
f28de4f
Some cleanup in CustomHierarchies class
franzpoeschel Aug 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,7 @@ endif()
set(CORE_SOURCE
src/config.cpp
src/ChunkInfo.cpp
src/CustomHierarchy.cpp
src/Dataset.cpp
src/Datatype.cpp
src/Error.cpp
Expand Down Expand Up @@ -616,6 +617,7 @@ if(openPMD_HAVE_PYTHON)
src/binding/python/Attributable.cpp
src/binding/python/BaseRecordComponent.cpp
src/binding/python/ChunkInfo.cpp
src/binding/python/CustomHierarchy.cpp
src/binding/python/Dataset.cpp
src/binding/python/Datatype.cpp
src/binding/python/Error.cpp
Expand Down Expand Up @@ -787,6 +789,7 @@ set(openPMD_PYTHON_EXAMPLE_NAMES
11_particle_dataframe
12_span_write
13_write_dynamic_configuration
14_custom_hierarchy
)

if(openPMD_USE_INVASIVE_TESTS)
Expand Down
48 changes: 48 additions & 0 deletions examples/14_custom_hierarchy.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
import numpy as np
import openpmd_api as io


def main():
if "bp" in io.file_extensions:
filename = "../samples/custom_hierarchy.bp"
else:
filename = "../samples/custom_hierarchy.json"
s = io.Series(filename, io.Access.create)
it = s.write_iterations()[100]

# write openPMD part
temp = it.meshes["temperature"]
temp.axis_labels = ["x", "y"]
temp.unit_dimension = {io.Unit_Dimension.T: 1}
temp.position = [0.5, 0.5]
temp.grid_spacing = [1, 1]
temp.grid_global_offset = [0, 0]
temp.reset_dataset(io.Dataset(np.dtype("double"), [5, 5]))
temp[()] = np.zeros((5, 5))

# write NeXus part
nxentry = it["Scan"]
nxentry.set_attribute("NX_class", "NXentry")
nxentry.set_attribute("default", "data")

data = nxentry["data"]
data.set_attribute("NX_class", "NXdata")
data.set_attribute("signal", "counts")
data.set_attribute("axes", ["two_theta"])
data.set_attribute("two_theta_indices", [0])

counts = data.as_container_of_datasets()["counts"]
counts.set_attribute("units", "counts")
counts.set_attribute("long_name", "photodiode counts")
counts.reset_dataset(io.Dataset(np.dtype("int"), [15]))
counts[()] = np.zeros(15, dtype=np.dtype("int"))

two_theta = data.as_container_of_datasets()["two_theta"]
two_theta.set_attribute("units", "degrees")
two_theta.set_attribute("long_name", "two_theta (degrees)")
two_theta.reset_dataset(io.Dataset(np.dtype("double"), [15]))
two_theta[()] = np.zeros(15)


if __name__ == "__main__":
main()
256 changes: 256 additions & 0 deletions include/openPMD/CustomHierarchy.hpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,256 @@
/* Copyright 2023 Franz Poeschel
*
* This file is part of openPMD-api.
*
* openPMD-api is free software: you can redistribute it and/or modify
* it under the terms of of either the GNU General Public License or
* the GNU Lesser General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* openPMD-api is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License and the GNU Lesser General Public License
* for more details.
*
* You should have received a copy of the GNU General Public License
* and the GNU Lesser General Public License along with openPMD-api.
* If not, see <http://www.gnu.org/licenses/>.
*/
#pragma once

#include "openPMD/IO/AbstractIOHandler.hpp"
#include "openPMD/Mesh.hpp"
#include "openPMD/ParticleSpecies.hpp"
#include "openPMD/RecordComponent.hpp"
#include "openPMD/backend/Container.hpp"

#include <memory>
#include <regex>
#include <set>
#include <stdexcept>
#include <string>
#include <type_traits>
#include <utility>
#include <vector>

namespace openPMD
{
class CustomHierarchy;
namespace internal
{
enum class ContainedType
{
Group,
Mesh,
Particle
};
struct MeshesParticlesPath
{
std::regex meshRegex;
std::set<std::string> collectNewMeshesPaths;
std::regex particleRegex;
std::set<std::string> collectNewParticlesPaths;

/*
* These values decide which path will be returned upon use of the
* shorthand notation s.iterations[0].meshes or .particles.
*
*/
std::string m_defaultMeshesPath = "meshes";
std::string m_defaultParticlesPath = "particles";

explicit MeshesParticlesPath() = default;
MeshesParticlesPath(
std::vector<std::string> const &meshes,
std::vector<std::string> const &particles);
MeshesParticlesPath(Series const &);

[[nodiscard]] ContainedType
determineType(std::vector<std::string> const &path) const;
[[nodiscard]] bool
isParticleContainer(std::vector<std::string> const &path) const;
[[nodiscard]] bool
isMeshContainer(std::vector<std::string> const &path) const;
};

struct CustomHierarchyData
: ContainerData<CustomHierarchy>
, ContainerData<RecordComponent>
, ContainerData<Mesh>
, ContainerData<ParticleSpecies>
{
explicit CustomHierarchyData();

void syncAttributables();

#if 0
inline Container<CustomHierarchy> customHierarchiesWrapped()
{
Container<CustomHierarchy> res;
res.setData(
{static_cast<ContainerData<CustomHierarchy> *>(this),
[](auto const *) {}});
return res;
}
#endif
inline Container<RecordComponent> embeddedDatasetsWrapped()
{
Container<RecordComponent> res;
res.setData(
{static_cast<ContainerData<RecordComponent> *>(this),
[](auto const *) {}});
return res;
}
inline Container<Mesh> embeddedMeshesWrapped()
{
Container<Mesh> res;
res.setData(
{static_cast<ContainerData<Mesh> *>(this),
[](auto const *) {}});
return res;
}

inline Container<ParticleSpecies> embeddedParticlesWrapped()
{
Container<ParticleSpecies> res;
res.setData(
{static_cast<ContainerData<ParticleSpecies> *>(this),
[](auto const *) {}});
return res;
}

#if 0
inline Container<CustomHierarchy>::InternalContainer &
customHierarchiesInternal()
{
return static_cast<ContainerData<CustomHierarchy> *>(this)
->m_container;
}
#endif
inline Container<RecordComponent>::InternalContainer &
embeddedDatasetsInternal()
{
return static_cast<ContainerData<RecordComponent> *>(this)
->m_container;
}
inline Container<Mesh>::InternalContainer &embeddedMeshesInternal()
{
return static_cast<ContainerData<Mesh> *>(this)->m_container;
}

inline Container<ParticleSpecies>::InternalContainer &
embeddedParticlesInternal()
{
return static_cast<ContainerData<ParticleSpecies> *>(this)
->m_container;
}
};
} // namespace internal

template <typename MappedType>
class ConversibleContainer : public Container<MappedType>
{
template <typename>
friend class ConversibleContainer;

protected:
using Container_t = Container<MappedType>;
using Data_t = internal::CustomHierarchyData;
static_assert(
std::is_base_of_v<typename Container_t::ContainerData, Data_t>);

ConversibleContainer(Attributable::NoInit)
: Container_t(Attributable::NoInit{})
{}

std::shared_ptr<Data_t> m_customHierarchyData;

[[nodiscard]] Data_t &get()
{
return *m_customHierarchyData;
}
[[nodiscard]] Data_t const &get() const
{
return *m_customHierarchyData;
}

inline void setData(std::shared_ptr<Data_t> data)
{
m_customHierarchyData = data;
Container_t::setData(std::move(data));
}

public:
template <typename TargetType>
auto asContainerOf() -> ConversibleContainer<TargetType>
{
if constexpr (
std::is_same_v<TargetType, CustomHierarchy> ||
std::is_same_v<TargetType, Mesh> ||
std::is_same_v<TargetType, ParticleSpecies> ||
std::is_same_v<TargetType, RecordComponent>)
{
ConversibleContainer<TargetType> res(Attributable::NoInit{});
res.setData(m_customHierarchyData);
return res;
}
else
{
static_assert(
auxiliary::dependent_false_v<TargetType>,
"[CustomHierarchy::asContainerOf] Type parameter must be "
"one of: CustomHierarchy, RecordComponent, Mesh, "
"ParticleSpecies.");
}
}
};

class CustomHierarchy : public ConversibleContainer<CustomHierarchy>
{
friend class Iteration;
friend class Container<CustomHierarchy>;

private:
using Container_t = Container<CustomHierarchy>;
using Parent_t = ConversibleContainer<CustomHierarchy>;
using Data_t = typename Parent_t::Data_t;

using EraseStaleMeshes = internal::EraseStaleEntries<Container<Mesh>>;
using EraseStaleParticles =
internal::EraseStaleEntries<Container<ParticleSpecies>>;
void readNonscalarMesh(EraseStaleMeshes &map, std::string const &name);
void readScalarMesh(EraseStaleMeshes &map, std::string const &name);
void readParticleSpecies(EraseStaleParticles &map, std::string const &name);

protected:
CustomHierarchy();
CustomHierarchy(NoInit);

void read(internal::MeshesParticlesPath const &);
void read(
internal::MeshesParticlesPath const &,
std::vector<std::string> &currentPath);

void flush_internal(
internal::FlushParams const &,
internal::MeshesParticlesPath &,
std::vector<std::string> currentPath);
void flush(std::string const &path, internal::FlushParams const &) override;

/**
* @brief Link with parent.
*
* @param w The Writable representing the parent.
*/
void linkHierarchy(Writable &w) override;

public:
CustomHierarchy(CustomHierarchy const &other) = default;
CustomHierarchy(CustomHierarchy &&other) = default;

CustomHierarchy &operator=(CustomHierarchy const &) = default;
CustomHierarchy &operator=(CustomHierarchy &&) = default;
};
} // namespace openPMD
3 changes: 2 additions & 1 deletion include/openPMD/IO/JSON/JSONIOHandlerImpl.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,8 @@ class JSONIOHandlerImpl : public AbstractIOHandlerImpl

// make sure that the given path exists in proper form in
// the passed json value
static void ensurePath(nlohmann::json *json, std::string const &path);
static void
ensurePath(nlohmann::json *json, std::string const &path, Access);

// In order not to insert the same file name into the data structures
// with a new pointer (e.g. when reopening), search for a possibly
Expand Down
Loading
Loading