-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added async write flag for ADIOS2 #1460
Conversation
Any idea why the test fail with hdf5 on Conda_ompi_all fails on ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please document the additional parameter in adios2.rst
?
Also, note that in BP5, openPMD will flush to disk by default which makes no sense in combination with async I/O. So, if you add an environment variable for this, it probably makes sense to flip that default in this case.
Will do
Yes, I had to flip the PerformDataWrite. I wonder whether this should an option as well. |
I think that we don't need an extra option for this. I added a commit that sets the default flush target to the Buffer when using this env var. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The failing docs PR run concerns all PRs currently and has nothing to do with this PR.
That will do. Thanks. |
3dd6191
to
990f2e2
Compare
please add a PR description, including links to ADIOS2 docs about the added feature
This PR adds a new env variable OPENPMD_ADIOS2_ASYNC_WRITE. Default = 0. When set to 1, it sets the ADIOS parameter "AsyncWrite" to "on". In which case the BP5 engine will handle write calls asynchronously.
See https://adios2.readthedocs.io/en/latest/engines/engines.html#bp5
for details of BP5 feature "AsyncWrite".