-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDF5: Handle unknown datatypes in datasets #1469
Conversation
Thanks for the patch! This seems to fail on 32bit Windows right now @franzpoeschel |
Does this need test coverage? :) |
abc5c49
to
2a7fada
Compare
The Windows tests look like a random failure. EDIT: Yep, after restarting the CI, it runs fine. |
2a7fada
to
5171ad9
Compare
For testing, we'll need openPMD/openPMD-example-datasets#20 |
3195cae
to
4c24ef7
Compare
4c24ef7
to
3d5f8c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
34e6ff3
to
b6b75d5
Compare
First commit: Throw
error::ReadError
inHDF5IOHandlerImpl::openDataset()
. Upon encountering an error, the middle-end will know that something has gone wrong that it can then recover from, skipping the dataset.Second commit: Sometimes, datasets use custom datatypes based on a native type. This can be supported by checking the parent datatypes if the actual datatypes is not recognized. See here for an example that uses enums to emulate booleans.