Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling for file extensions #1473

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

franzpoeschel
Copy link
Contributor

Close #1471

This also takes the chance to support filenames with a trailing slash, this kept annoying me. (BP files generally create folders and Bash completion will add a trailing slash)

@franzpoeschel franzpoeschel force-pushed the better-handling-file-extensions branch from ada9c30 to 7542a3f Compare July 10, 2023 09:27
@franzpoeschel franzpoeschel mentioned this pull request Jul 10, 2023
4 tasks
@franzpoeschel franzpoeschel added this to the 0.15.3 milestone Jul 13, 2023
@ax3l ax3l modified the milestones: 0.15.3, 0.15.2 Jul 18, 2023
@ax3l ax3l self-assigned this Jul 18, 2023
@ax3l ax3l self-requested a review July 18, 2023 17:50
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@ax3l ax3l merged commit 9365031 into openPMD:dev Jul 18, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear error message for unsupported file format
2 participants