Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Series to DataFrame #1506

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Python: Series to DataFrame #1506

merged 2 commits into from
Aug 5, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Aug 16, 2023 •
edited
Loading

Add new helpers to create Pandas and cuDF dataframes for a single particle species, over all iterations at once.

  • add tests

@ax3l ax3l added third party third party libraries that are shipped and/or linked frontend: Python3 labels Aug 16, 2023
@ax3l ax3l added this to the 0.16.0 milestone Aug 16, 2023
@ax3l ax3l force-pushed the doc-siers-to-dataframes branch 5 times, most recently from 4e2ab4a to e004150 Compare August 17, 2023 00:36
@ax3l ax3l force-pushed the doc-siers-to-dataframes branch 2 times, most recently from 0f2299e to f9fb965 Compare August 17, 2023 03:13
@ax3l
Python: Series to DataFrame
cb5041d 
Add new helpers to create Pandas and cuDF dataframes for a single
particle species, over all iterations at once.
@ax3l ax3l mentioned this pull request Jul 30, 2024
Open
franzpoeschel
franzpoeschel requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@franzpoeschel franzpoeschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two small hardcoded parameters that you probably meant to replace still.
Looks good otherwise, thank you!

src/binding/python/openpmd_api/DataFrame.py Outdated Show resolved Hide resolved
src/binding/python/openpmd_api/DataFrame.py Outdated Show resolved Hide resolved
@ax3l @franzpoeschel
Remove hard-coded species name
fd76761 
Co-authored-by: Franz Pöschel <[email protected]>
@ax3l
Copy link
Member Author

ax3l commented Aug 1, 2024

Ouch, good catch! Thank you, fixed now.

@ax3l ax3l requested a review from franzpoeschel August 1, 2024 17:31
@franzpoeschel franzpoeschel merged commit ff21bbc into openPMD:dev Aug 5, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franzpoeschel franzpoeschel franzpoeschel approved these changes

Assignees

@franzpoeschel franzpoeschel

Labels
frontend: Python3 third party third party libraries that are shipped and/or linked
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ax3l @franzpoeschel