Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Spack v0.22.1 #1597

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

CI: Spack v0.22.1 #1597

wants to merge 9 commits into from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Feb 26, 2024

Update Spack in CI to the latest stable release.

Will need:

As a follow up

@ax3l ax3l force-pushed the ci-spack-0.21.1 branch 3 times, most recently from c453afd to b79d928 Compare February 26, 2024 23:26
@ax3l ax3l changed the title CI: Spack v0.21.1 CI: Spack v0.21.2 Mar 12, 2024
.github/workflows/linux.yml Outdated Show resolved Hide resolved
@ax3l ax3l added this to the 0.16.0 milestone Jun 11, 2024
@ax3l ax3l changed the title CI: Spack v0.21.2 CI: Spack v0.22.0 Jun 11, 2024
.github/workflows/linux.yml Outdated Show resolved Hide resolved
@ax3l ax3l changed the title CI: Spack v0.22.0 CI: Spack v0.22.1 Jul 19, 2024
Destructor may run after the flag has been deleted. Not even Valgrind
caught this.
@franzpoeschel
Copy link
Contributor

The latest commit fixes the UBSAN issue. UBSAN correctly detected a memory issue it didnt before.

@ax3l
Copy link
Member Author

ax3l commented Jul 30, 2024

Thanks a lot! Can you isolate the last commit as a bugfix PR for 0.16.0?

@franzpoeschel
Copy link
Contributor

Thanks a lot! Can you isolate the last commit as a bugfix PR for 0.16.0?

#1657, done

@ax3l
Copy link
Member Author

ax3l commented Aug 5, 2024

This spack/spack#45582 worked for me locally, let's see if it fixes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants