-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADIOS2 variable shape LocalValue #1601
Open
franzpoeschel
wants to merge
13
commits into
openPMD:dev
Choose a base branch
from
franzpoeschel:adios2-local-values
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzpoeschel
force-pushed
the
adios2-local-values
branch
3 times, most recently
from
March 12, 2024 10:50
a342b5d
to
88b01e8
Compare
ax3l
reviewed
Mar 12, 2024
ax3l
reviewed
Mar 25, 2024
franzpoeschel
force-pushed
the
adios2-local-values
branch
from
March 26, 2024 13:45
29bc62c
to
acfdbf3
Compare
franzpoeschel
force-pushed
the
adios2-local-values
branch
from
May 8, 2024 13:32
164bf28
to
950da6d
Compare
franzpoeschel
force-pushed
the
adios2-local-values
branch
from
May 21, 2024 14:58
950da6d
to
b0bf166
Compare
franzpoeschel
force-pushed
the
adios2-local-values
branch
from
June 26, 2024 11:47
ce148d0
to
14d029c
Compare
franzpoeschel
force-pushed
the
adios2-local-values
branch
from
July 11, 2024 13:14
14d029c
to
7a01376
Compare
Copied from HDF5 backend
Co-authored-by: Axel Huebl <[email protected]>
Co-authored-by: Axel Huebl <[email protected]>
how did that line even get in there
franzpoeschel
force-pushed
the
adios2-local-values
branch
from
August 5, 2024 09:48
7a01376
to
6bba84e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://adios2.readthedocs.io/en/v2.9.2/components/components.html#shapes
This PR considers LocalValues in ADIOS2 merely an implementation detail, without actually exposing an API analogous to to how LocalValues work in ADIOS2.
The reasoning is:
TODO