Fix Python container and pickle API #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzpoeschel
force-pushed
the
fix-python-container-and-pickle-api
branch
from
4ae7a3f
to
f72e899
Compare
ax3l
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1154.
In the Python API, it was so far impossible to actually get a handle to a scalar record component due to the reference return type of
__getitem__. Python was smart enough to find out the actual type of the reference: the scalar record component IS its containing Record.This can lead to problems such as infinite recursion when traversing over the object model in our Python API.
This additionally meant that no one ever noticed that I forgot handling scalar record components in #1154 for Python pickling, since those objects were impossible to obtain in Python. This adds the missing logic.