-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flush target newstep #1632
Merged
Merged
Flush target newstep #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzpoeschel
force-pushed
the
flush_target_newstep
branch
from
June 12, 2024 11:13
c08d260
to
11279f6
Compare
franzpoeschel
commented
Jun 12, 2024
2 tasks
franzpoeschel
force-pushed
the
flush_target_newstep
branch
from
June 25, 2024 12:05
f099a4e
to
2feae75
Compare
franzpoeschel
force-pushed
the
flush_target_newstep
branch
from
July 16, 2024 09:32
2feae75
to
247b01e
Compare
ax3l
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome.
Let us also add a parallel test to cover serial and parallel I/O.
Done as part of follow-up #1638 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adios2.engine.mode = "what's the name of the mode that we need here does it even exist yet help"
It seems this needs no explicit reading logic, just
io.SetParameters("FlattenSteps=on");
on the writer side?Automatically add that option in file-based encodingNot possible without breaking other workflowsIntroduces a new flush target
"new_step"
used for creating readable output in file-based iteration encoding while the Iteration is not yet fully defined yet.Close #1629