CI fixes and documentation for Pybind v2.12.0 and Numpy 2.0 #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -2406,13 +2465,15 @@ | |||
| typename Sentinel, | |||
| typename ValueType = typename detail::iterator_access<Iterator>::result_type, | |||
| typename... Extra> | |||
| iterator make_iterator(Iterator first, Sentinel last, Extra &&...extra) { | |||
| typing::Iterator<ValueType> make_iterator(Iterator first, Sentinel last, Extra &&...extra) { | |||
Check notice
Code scanning / CodeQL
Unused static variable Note
| @@ -2422,13 +2483,15 @@ | |||
| typename Sentinel, | |||
| typename KeyType = typename detail::iterator_key_access<Iterator>::result_type, | |||
| typename... Extra> | |||
| iterator make_key_iterator(Iterator first, Sentinel last, Extra &&...extra) { | |||
| typing::Iterator<KeyType> make_key_iterator(Iterator first, Sentinel last, Extra &&...extra) { | |||
Check notice
Code scanning / CodeQL
Unused static variable Note
| @@ -2406,13 +2465,15 @@ | |||
| typename Sentinel, | |||
| typename ValueType = typename detail::iterator_access<Iterator>::result_type, | |||
| typename... Extra> | |||
| iterator make_iterator(Iterator first, Sentinel last, Extra &&...extra) { | |||
| typing::Iterator<ValueType> make_iterator(Iterator first, Sentinel last, Extra &&...extra) { | |||
Check notice
Code scanning / CodeQL
Unused local variable Note
| @@ -2422,13 +2483,15 @@ | |||
| typename Sentinel, | |||
| typename KeyType = typename detail::iterator_key_access<Iterator>::result_type, | |||
| typename... Extra> | |||
| iterator make_key_iterator(Iterator first, Sentinel last, Extra &&...extra) { | |||
| typing::Iterator<KeyType> make_key_iterator(Iterator first, Sentinel last, Extra &&...extra) { | |||
Check notice
Code scanning / CodeQL
Unused local variable Note
franzpoeschel
force-pushed
the
check-ci-on-dev
branch
11 times, most recently
from
d1b1220
to
f86386e
Compare
franzpoeschel
changed the title
franzpoeschel
force-pushed
the
check-ci-on-dev
branch
2 times, most recently
from
c794d05
to
5d41f83
Compare
franzpoeschel
changed the title
franzpoeschel
force-pushed
the
check-ci-on-dev
branch
from
5d41f83
to
2e22b52
Compare
franzpoeschel
changed the title
ax3l
reviewed
Jun 24, 2024
.github/workflows/linux.yml
Outdated
Comment on lines
132
to
137
| # compatibility issues between the two versions. | ||
| sudo apt -y autoremove python3 | ||
| sudo apt install clang-14 cmake gfortran libhdf5-dev python3.11 python3.11-dev wget | ||
| python="$(which python3.11)" | ||
| sudo ln -s "$python" "${python%.11}" | ||
| sudo ln -s "$python" "${python%3.11}" |
There was a problem hiding this comment.
I'm not using a venv here, but I can try it as an alternative
There was a problem hiding this comment.
Yep, that works too. I just have to take care that Spack does not use the venv since it will try finding headers inside the venv.
franzpoeschel
force-pushed
the
check-ci-on-dev
branch
4 times, most recently
from
5b83753
to
658a633
Compare
franzpoeschel
force-pushed
the
check-ci-on-dev
branch
2 times, most recently
from
c403034
to
04b0471
Compare
franzpoeschel
force-pushed
the
check-ci-on-dev
branch
from
04b0471
to
69c481c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the Pybind upgrade to v2.12.0 and the Numpy upgrade to v2.0, some previous CI setup warnings turned into errors, leading to broken Python imports. Fix by (1) removing conflicting Python versions or (2) using Python virtualenvs.
#1640 and this (#1637) are two separate PRs since I don't want to squash the commits, #1640 has another author (third-party lib).