-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: CMake Internal Control #1678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
fix-cmake-internal
branch
from
October 8, 2024 17:46
ccf3054
to
b41d157
Compare
ax3l
force-pushed
the
fix-cmake-internal
branch
from
October 8, 2024 17:51
b41d157
to
5e85670
Compare
ax3l
force-pushed
the
fix-cmake-internal
branch
from
October 8, 2024 17:53
5e85670
to
47bcafb
Compare
ax3l
added a commit
to regro-cf-autotick-bot/openpmd-api-feedstock
that referenced
this pull request
Oct 8, 2024
ax3l
added a commit
to ax3l/spack
that referenced
this pull request
Oct 8, 2024
openPMD/openPMD-api#1678 Signed-off-by: Axel Huebl <[email protected]>
ax3l
added a commit
to openPMD/homebrew-openPMD
that referenced
this pull request
Oct 8, 2024
The `openPMD_USE_INTERNAL_*` options are for general internal/external control. They were accidentally overwritten by new tar flags and sometimes incomplete. Signed-off-by: Axel Huebl <[email protected]>
ax3l
force-pushed
the
fix-cmake-internal
branch
from
October 8, 2024 18:19
47bcafb
to
bcb1e17
Compare
ax3l
added a commit
to ax3l/spack
that referenced
this pull request
Oct 8, 2024
openPMD/openPMD-api#1678 Signed-off-by: Axel Huebl <[email protected]>
ax3l
added a commit
to openPMD/homebrew-openPMD
that referenced
this pull request
Oct 8, 2024
ax3l
added a commit
to ax3l/spack
that referenced
this pull request
Oct 8, 2024
openPMD/openPMD-api#1678 Signed-off-by: Axel Huebl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thank you!
franzpoeschel
added a commit
to ax3l/openPMD-api
that referenced
this pull request
Oct 10, 2024
ax3l
added a commit
to spack/spack
that referenced
this pull request
Oct 10, 2024
* openPMD-api: 0.16.0 Signed-off-by: Axel Huebl <[email protected]> * [Patch] Fix: CMake Internal Control openPMD/openPMD-api#1678 Signed-off-by: Axel Huebl <[email protected]>
arezaii
pushed a commit
to arezaii/spack
that referenced
this pull request
Oct 22, 2024
* openPMD-api: 0.16.0 Signed-off-by: Axel Huebl <[email protected]> * [Patch] Fix: CMake Internal Control openPMD/openPMD-api#1678 Signed-off-by: Axel Huebl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
openPMD_USE_INTERNAL_*
options are for general internal/external control. They were accidentally overwritten by new tar flags and sometimes incomplete.Follow-up to #1668