Fix Leftover ADIOS1 Mentions #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
fix-adios1-mentions
branch
from
015d9e7
to
284debf
Compare
I pushed a commit that does this, I think this PR is fine for it |
franzpoeschel
approved these changes
Oct 11, 2024
franzpoeschel
approved these changes
Oct 29, 2024
Signed-off-by: Axel Huebl <[email protected]>
franzpoeschel
force-pushed
the
fix-adios1-mentions
branch
from
5f4089a
to
c79e332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaves the doc page on ADIOS1 for now in, because it contains a migration guide on how to read legacy BP3 files.
Note: Examples 7 and 13 still mention adios1 options, which will need a separate PR to update.