Z vm fixes #916
Open
Z vm fixes #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each log message created with .log will contain a severity, the originating file and the function where the log had been called. The function is called with: .log <severity> <message> where severity is defined in https://en.wikipedia.org/wiki/Syslog#Severity_level
In z/VM, the system representation of the SWAP device is just a four digit hex number. However, the build script expects a partition within a disk instead. This change rewrites the device number into a block device when needed.
The IUCV console connection is not always responding fast enough, therefore loop until the connection works. This change also removes the creation of a specific initrd, since the default has all needed modules available.
|
This way of logging is conflicting with our current idea of debug logging, we do not want to increase or decrease all kinds of logs, but we want to enable logging for specific areas. We want to enable logging by a specified area (eg. zvm, kvm or all vm handling) and enable debug logging only for these kind of operations. Could you adapt your zvm worker fixes just to check for BUILD_VERBOSE_VM=true for example? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the changes, that I currently use to operate the z/VM worker on OBS. In order to simplify the debugging and logging of the worker, I also added a function ".log" that allows to specify a certain log level and to print out the affected file and function within that file.
.log 5 "This is a notice"
The severity levels are used from https://en.wikipedia.org/wiki/Syslog#Severity_level
The default severity level is set to 4, to keep the default output clean.
Feel free to do changes if needed.