Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces support for instantiating packages from remote project links #16226

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hennevogel
Copy link
Member

@hennevogel hennevogel commented May 29, 2024

Instead of returning nil for packages that might come from an remote project link, check if they are known to the backend and return an in-memory, read only Package object.

Instead of returning nil for packages that might come from an remote project
link, check if they are known to the backend and return an in-memory, read only
Package object.
Package.get_by_project_and_name gained support for instantiating Package
objects from remote project links.
@github-actions github-actions bot added Frontend Things related to the OBS RoR app Test Suite / CI 💉 Things related to our tests/CI labels May 29, 2024
@hennevogel
Copy link
Member Author

hennevogel commented May 31, 2024

TODO:

  • Project#show view should list the packages in an "Inherited Packages" tab somehow...
  • Package#show view The "derived packages" information is showing something weird...
  • Package#repositores view has no indicator that it's read only
  • Package#revisions view: Links to links (home:hennevogel/cloc links to home:hennevogel/cloc on OBS which is a link to Documentation:Tools/cloc on OBS) show "No commits exists yet."
  • Package#users view has no indicator that it's read only
  • Package#attributes view has no indicator that it's read only
  • Package#meta view has no indicator that it's read only
  • Branching a package leads to a weird package because the BackendPackage does not consider linked information from the backend
  • Requests from a readonly package (like obs-test#10) don't show a package link
    Screenshot from 2024-05-31 15-18-51
  • Request Role Addition side-link does not work. Additionally it is shown to people who have write access to the project.
  • "Request Deletion" side-link does not work either. Additionally it is shown to people who have write access to the project.
  • "Report this package" side-link is broken too. Additionally it is shown to people who have write access to the project.
  • Watchlist functionality does not work for the package

@hennevogel hennevogel added the DO NOT MERGE ⚠️ Explain yourself if you add/remove this label to a PR label May 31, 2024
@hennevogel
Copy link
Member Author

Do not merge this.

It needs some more sophisticated authorization setup. We probably want to switch the default of the option and then explicitly enable this per Package.get_by_project_and_name call and figure out problems first....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE ⚠️ Explain yourself if you add/remove this label to a PR Frontend Things related to the OBS RoR app Test Suite / CI 💉 Things related to our tests/CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant