openldap2_5 support for SLES #238
Open
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thr3d
requested changes
Jan 6, 2025
this would generate something like this;
``` shell
$ tar xOJf /var/log/scc_jb155sapqe01_250106_1959.txz scc_jb155sapqe01_250106_1959/ldap.txt | \
sed -n '/openldap2_5/p; /slapd.service/p; /^# \/etc\/openldap\/ldap.conf$/,/^#==/p'# /etc/openldap/ldap.conf
URI ldap://jbw2k22qe01.example.com
BASE dc=example,dc=com
REFERRALS OFF
#==[ Command ]======================================#
# rpm -V openldap2_5-2.5.17+50-150500.11.3.1.x86_64
# /bin/systemctl status slapd.service
○ slapd.service - OpenLDAP Server Daemon
Loaded: loaded (/usr/lib/systemd/system/slapd.service; disabled; preset: disabled)
```
Thr3d
requested changes
Jan 13, 2025
There was a problem hiding this comment.
While I like the idea behind it, the change to rpm_verify() is problematic. By adding the -a you've nearly doubled the time it takes for supportconfig to run on a fresh install.
Please remove the changes to rpm_verify() and call rpm_verify for each package.
sssd_info() for example does this:
if rpm_verify $OF sssd; then
rpm_verify $OF sssd-tool
rpm_verify $OF python-sssd-config
If you open a PR for the rpm_verify() change we can revist that. Doesn't look like that will be as simple as just dropping the -a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.