Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of base uri #72

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

grafst
Copy link

@grafst grafst commented Nov 16, 2023

This is very useful to use drop in replacements of the openai-api for local models.

This is very useful to use drop in replacements of the openai-api for local models.
@gehrisandro
Copy link
Collaborator

Hi @grafst

Thank you for your PR.

It looks like this is introducing a breaking change, because it will fail for all existing users not having the base_uri in their configuration file.
I think this can be fixed, by making the default null and only set the baseUri if a configuration exists and is not null.

And in my opinion there is no need to validate if the base uri is a string. Maybe we can just enforce a string casting.

@grafst
Copy link
Author

grafst commented Nov 17, 2023

yes you are totally right, it should just ignore if the config is not present.
Oh and really sorry I didn't see the other PR before :(

Is this now better?

@Xinecraft
Copy link

Hi,
Any update on getting this resolved and merged? or a new PR should be created?

@debjit
Copy link

debjit commented Feb 17, 2024

So we still do not have any option to pass a custom URL for self-hosting LLM? Or just have to pass as an HTTP request?

@grafst
Copy link
Author

grafst commented Feb 18, 2024 via email

@giltotherescue
Copy link

I would also love to see this added. Am hoping to use this along with openrouter.ai to get access to many different models from one interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants