[app-server] Make sure that config writes preserve comments & order or configs #7789
+189
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celia-oai
force-pushed
the
dev/cc/fix-config
branch
3 times, most recently
from
a7d0add to
4144031
Compare
celia-oai
force-pushed
the
dev/cc/fix-config
branch
2 times, most recently
from
0c88d58 to
256b084
Compare
celia-oai
changed the title
celia-oai
force-pushed
the
dev/cc/fix-config
branch
from
256b084 to
02aafa2
Compare
jif-oai
approved these changes
Dec 10, 2025
Collaborator
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
Small Rust nits but lgtm
Good work
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that config writes preserve comments and order of configs by utilizing the ConfigEditsBuilder in core.
Tested by running a real example and made sure that nothing in the config file changes other than the configs to edit.