chore(shell_command) add tests to verify timeout_ms #7791
+66
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylan-hurd-oai
force-pushed
the
dh--shell-command--timeout-tests
branch
from
0690aa0 to
3f6c99d
Compare
jif-oai
approved these changes
Dec 10, 2025
pakrym-oai
reviewed
Dec 10, 2025
pakrym-oai
reviewed
Dec 10, 2025
| .replace('\r', "\n") | ||
| .trim_end_matches('\n') | ||
| .to_string(); | ||
| let expected_pattern = r"(?s)^Exit code: 124\nWall time: [0-9]+(?:\.[0-9]+)? seconds\nOutput:(?:\ncommand timed out after [0-9]+ milliseconds)?\n?$"; |
Collaborator
There was a problem hiding this comment.
this regex is interesting. Is command timed out after message flaky?
Collaborator
Author
There was a problem hiding this comment.
@pakrym-oai what would you expect here, exact string match?
Collaborator
There was a problem hiding this comment.
I'd expect to see command timed out after [0-9]+ milliseconds on all platforms.
dylan-hurd-oai
force-pushed
the
dh--shell-command--timeout-tests
branch
from
1a9c6ff to
bd6d4af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding an additional integration test for timeout_ms
Testing