-
Notifications
You must be signed in to change notification settings - Fork 7.2k
fix(tui): avoid hard-wrapping URL lines in history #8757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(tui): avoid hard-wrapping URL lines in history #8757
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
joshka-oai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can go a bit deeper here and make an intelligent wrap before URLs a thing - i.e. when they'd wrap in the middle of the URL, force a wrap before. We will still need to character wrap when they're too long for the terminal regardless (and need tests for that scenario), but this would at least cut down the problems of not quite enough space to wrap. In effect, we want to treat the url as a word / non-breakable token somehow. This should probably also be in the wrapping code, not the insert_history code btw.
Strong support for fixing this. So please continue on this when you can.
What
Why
How
Testing