Enable model upgrade popup even when selected model is no longer in picker #8802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Collaborator
Author
|
I have read the CLA Document and I hereby sign the CLA |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f97815797f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
charley-oai
force-pushed
the
fix-model-upgrade-popup-for-invisible-selected-model
branch
from
f978157 to
e67b55f
Compare
charley-oai
force-pushed
the
fix-model-upgrade-popup-for-invisible-selected-model
branch
from
e67b55f to
f821de2
Compare
charley-oai
force-pushed
the
fix-model-upgrade-popup-for-invisible-selected-model
branch
from
f821de2 to
9fc047b
Compare
Collaborator
|
@codex is the changes in tui the same as tui2? It needs to be the same. fix it if not. |
Contributor
|
Summary
Testing
|
charley-oai
deleted the
fix-model-upgrade-popup-for-invisible-selected-model
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
config.toml:(where
gpt-5.1-codexhasshow_in_picker: falseinmodel_presets.rs; this happens if the user hasn't used codex in a while so they didn't see the popup before their model was changed toshow_in_picker: false)The upgrade picker used to not show (because
gpt-5.1-codexwas filtered out of the model list in code). Now, the filtering is done downstream in tui and app-server, so the model upgrade popup shows: