fix: avoid sandbox denial false positives #8895
Open
+14
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorders the sandbox-denied heuristic in codex-rs/core/src/exec.rs so quick-reject exit codes (2/126/127) short-circuit before keyword scanning.
This prevents normal shell errors like permission denied or command not found from being misclassified as sandbox denials, and it looks like a regression because git history shows the original quick-reject intent (Aug 3/Oct 9 commits) was to skip those exit codes before any keyword checks, but the Oct 20 tools workflow refactor moved the check after keyword matching without an intentional behavior change.
References: