feat: first pass on clb tool #8930
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcc89596eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| let _timeout_ms = timeout_ms.min(MAX_WAIT_TIMEOUT_MS); | ||
| // TODO(jif): implement agent wait once lifecycle tracking is wired up. | ||
| Err(FunctionCallError::Fatal("wait not implemented".to_string())) |
There was a problem hiding this comment.
With Feature::Collab enabled, build_specs registers the wait tool, so the model is allowed to call it; this handler always returns FunctionCallError::Fatal, which ToolRouter::dispatch_tool_call treats as a hard failure rather than a tool output. That means any wait call will abort the entire turn instead of returning a normal tool failure, making the collab flow unusable whenever the model tries to wait. Consider hiding the tool until implemented or returning a non-fatal failure response.
Useful? React with 👍 / 👎.
| Err(FunctionCallError::Fatal( | ||
| "close_agent not implemented".to_string(), |
There was a problem hiding this comment.
The close_agent tool is also registered when collab is enabled, but its handler always returns FunctionCallError::Fatal. Since fatal tool errors short-circuit dispatch instead of producing a tool failure output, any close_agent call will fail the entire turn. If this tool is exposed to the model before being implemented, it will cause abrupt failures rather than a recoverable tool error.
Useful? React with 👍 / 👎.
No description provided.