Skip to content

Conversation

@bolinfest
Copy link
Collaborator

@bolinfest bolinfest commented Jan 8, 2026

Because the path to git is used to construct elicitations_to_accept, we need to ensure that we resolve which git to use the same way our Bash process will:

let git_path = resolve_git_path().await?;
let expected_elicitation_message = format!(
"Allow agent to run `{} init .` in `{}`?",
git_path,
project_root_path.display()
);
let elicitation_requests: Arc<Mutex<Vec<CreateElicitationRequestParam>>> = Default::default();
let client = InteractiveClient {
elicitations_to_accept: hashset! { expected_elicitation_message.clone() },
elicitation_requests: elicitation_requests.clone(),
};

This fixes an issue when running the test on macOS using Bazel (#8875) where the login shell chose /opt/homebrew/bin/git whereas the non-login shell chose /usr/bin/git.

@bolinfest bolinfest merged commit a70f5b0 into main Jan 8, 2026
45 of 47 checks passed
@bolinfest bolinfest deleted the pr8931 branch January 8, 2026 20:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants