-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Add hierarchical agent prompt #8996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move HIERARCHICAL_AGENTS_MESSAGE into project_doc.rs and build user instructions with a single String buffer instead of a Vec join. Remove prompt_instructions helper and related tests.
aibrahim-oai
reviewed
Jan 9, 2026
aibrahim-oai
reviewed
Jan 9, 2026
| skills: Option<&[SkillMetadata]>, | ||
| ) -> Option<String> { | ||
| let skills_section = skills.and_then(render_skills_section); | ||
| let project_docs = read_project_docs(config).await; |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why so big of a change for appending instructions?
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simplify all various places we concat things, just one function that builds the final output./
aibrahim-oai
reviewed
Jan 9, 2026
aibrahim-oai
approved these changes
Jan 9, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.