fix(tui): document and harden paste-burst state machine #9020
+1,514
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some terminals (notably Windows), multiline pastes arrive as a rapid stream of Char/Enter key events rather than a single paste event. ChatComposer treats these bursts as a small state machine so it can buffer the burst, suppress side effects (e.g. '?' overlay), and keep Enter as newline during the paste. This change documents the state machine in detail and adds small, deterministic tests that pin the tricky transitions: - Non-ASCII/IME path and retro-capture. - Enter suppression window and slash-command escape hatch. - Flushing on non-char keys (avoids a stuck buffer). - disable_paste_burst bypass + flushes pending first char. Also adds docs/tui-chat-composer.md plus a markdownlint-cli2 config (MD013 line length 100) for linting this doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Behavior changes
disable_paste_burstfully bypasses burst logic and flushes any pending held first char when toggled on.Tests
cd codex-rs && cargo test -p codex-tui bottom_pane::paste_burstcd codex-rs && cargo test -p codex-tui bottom_pane::chat_composercd codex-rs && cargo test -p codex-tui2 bottom_pane::paste_burstcd codex-rs && cargo test -p codex-tui2 bottom_pane::chat_composer