fix: send non-null content on elicitation Accept #9196
Merged
+6
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
content: Some(json!({}))instead ofNoneexec-server/tests/common/lib.rs:171Root Cause
In
codex-rs/core/src/codex.rs, theresolve_elicitationfunction always sentcontent: None:Fix
Send an empty object when accepting:
Test plan
cargo check -p codex-corejust fmtaccept_elicitation_for_prompt_rule(requires MCP server binary)Fixes #9053