wasm32-wasip2 support, fix wasm32-unknown-unknown#69
Open
elewis787 wants to merge 3 commits intoopenai:mainfrom
Open
wasm32-wasip2 support, fix wasm32-unknown-unknown#69elewis787 wants to merge 3 commits intoopenai:mainfrom
elewis787 wants to merge 3 commits intoopenai:mainfrom
Conversation
Author
|
For reference, you can see the wasip2 use case here https://github.com/hayride-dev/morphs/blob/main/components/ai/models/gptoss/src/lib.rs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing wasm32 support caused compile errors due to outdated code, largely using atomic bool that was no longer needed or imported.
Additionally, existing WASM support did not handle WASI or wasip2 due to the async HTTP client being used. This appears to work with the browsers' fetch support, but not when targeting WASI.
This PR attempts to add wasip2 support by introducing and updating the existing WASM32 code to compile.
The wasip2 support assumes this library will be used as a guest component. Ideally, libraries like reqwest will eventually include wasip2 support so we can avoid additional dependencies. For reference seanmonstar/reqwest#2294