Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0/n] Only run tests on py3.9, not mypy #319

Merged
merged 1 commit into from
Mar 25, 2025
Merged

[0/n] Only run tests on py3.9, not mypy #319

merged 1 commit into from
Mar 25, 2025

Conversation

rm-openai
Copy link
Collaborator

@rm-openai rm-openai commented Mar 24, 2025

We don't really need mypy on 3.9 (unit tests would catch any real issues), and it causes issues with the rest of this stack.


### Summary:
We don't need to run mypy on 3.9 anyway. Also it causes issues with the rest of this stack.

### Test plan:

run checks
@rm-openai rm-openai requested a review from stevenheidel March 24, 2025 19:08
@rm-openai rm-openai changed the title Only run tests on py3.9, not mypy [0/n] Only run tests on py3.9, not mypy Mar 24, 2025
@rm-openai rm-openai mentioned this pull request Mar 24, 2025
@rm-openai rm-openai merged commit 13abb68 into main Mar 25, 2025
10 checks passed
@rm-openai rm-openai deleted the rm/pr319 branch March 25, 2025 03:19
rm-openai added a commit that referenced this pull request Mar 25, 2025
### Summary:
1. Add the MCP dep for python 3.10, since it doesn't support 3.9 and
below
2. Create MCPServer, which is the agents SDK representation of an MCP
server
3. Create implementations for HTTP-SSE and StdIO servers, directly
copying the [MCP SDK
example](https://github.com/modelcontextprotocol/python-sdk/blob/main/examples/clients/simple-chatbot/mcp_simple_chatbot/main.py)
4. Add a util to transform MCP tools into Agent SDK tools

Note: I added optional caching support to the servers. That way, if you
happen to know a server's tools don't change, you can just cache them.

### Test Plan:

Checks pass. I added tests at the end of the stack.

--- 

#324
#322
#321
-> #320
#319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants