Add compatibility to the WSL - #113
Open
holmgrein wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The backend script is a Bash script (uses bash features and shebang). If a non-Bash shell runs it, it doesn’t understand ./run.sh, fails early, and produces “'.' is not recognized as an internal or external command”.
Solution
Changing the npm script to bash -lc './backend/scripts/run.sh' pins the shell to Bash, so:
◦ ./path execution works
◦ Bash features (set -euo pipefail, source, etc.) work
◦ Behavior is consistent in WSL, Git Bash, and Unix shells
What changed
• In managed-chatkit/package.json: scripts.backend from ./backend/scripts/run.sh to bash -lc './backend/scripts/run.sh'.
Alternatives you could use instead
• Add an .npmrc with script-shell set to bash globally for the repo.
• Change the script to a POSIX-sh compatible script and call sh ./backend/scripts/run.sh (only if it truly needs no Bash features).