Support both string and integer types for duration in TranslationVerbose #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ose. This update enhances the `TranslationVerbose` model by supporting both string and integer types for the `duration` field: - **Changed**: Updated the `duration` field type to `Union[str, int]` to allow both formats. - **Added**: A `__post_init__` method to ensure consistent handling of integer durations by converting them to strings internally. This change addresses potential usability issues where the duration might be provided as an integer but was previously expected as a string. **Impact**: Improves flexibility and usability for the `TranslationVerbose` model.
1 task
|
Thanks for the PR but the fact that it is a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update enhances the
TranslationVerbosemodel by supporting both string and integer types for thedurationfield:durationfield type toUnion[str, int]to allow both formats.__post_init__method to ensure consistent handling of integer durations by converting them to strings internally.This change addresses potential usability issues where the duration might be provided as an integer but was previously expected as a string.
Impact: Improves flexibility and usability for the
TranslationVerbosemodel.Changes Being Requested
Support for both string and integer values in the
durationfield of theTranslationVerbosemodel.Additional Context & Links
This change ensures better compatibility and reduces confusion when
durationis supplied as an integer.