Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

Commit

Permalink
[Dist/CI] Remove dist from target determinator (pytorch#64721)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: pytorch#64721

There are a couple PRs where distributed CI did not runa nd we expect
it to. Examples:

https://github.com/pytorch/pytorch/pull/64513/checks?check_run_id=3539190960,
pytorch#64113. All distributed tests should've
been run on these PRs, but we can see they were not:

```
Determination is skipping distributed/test_c10d_common
Determination is skipping distributed/test_c10d_gloo
Determination is skipping distributed/test_c10d_nccl
Determination is skipping distributed/test_c10d_spawn_gloo
Determination is skipping distributed/test_c10d_spawn_nccl
Running distributed/test_data_parallel without determination
Determination is skipping distributed/test_distributed_spawn
Determination is skipping distributed/test_jit_c10d
```

Since it is important to run distributed tests on PRs that touch distributed,
exclude distributed from target_det_list for now.
ghstack-source-id: 137654015

Test Plan: CI

Reviewed By: driazati, mrshenli

Differential Revision: D30830455

fbshipit-source-id: 8b0fdf5b57c2c647b0d82c48e2bb8e2bdbe4d307
  • Loading branch information
rohan-varma authored and facebook-github-bot committed Sep 9, 2021
1 parent 46c886e commit 9797a32
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 37 deletions.
1 change: 0 additions & 1 deletion test/test_determination.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ class DeterminationTest(unittest.TestCase):
"test_jit_profiling",
"test_jit",
"test_torch",
"distributed/test_distributed_spawn",
"test_cpp_extensions_aot_ninja",
"test_cpp_extensions_aot_no_ninja",
"test_utils",
Expand Down
36 changes: 0 additions & 36 deletions tools/testing/modulefinder_determinator.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,42 +12,6 @@
# run with --determine-from, we use another generated list based on this one and the
# previous test stats.
TARGET_DET_LIST = [
"distributed/algorithms/ddp_comm_hooks/test_ddp_hooks",
"distributed/nn/jit/test_instantiator",
"distributed/pipeline/sync/skip/test_api",
"distributed/pipeline/sync/skip/test_gpipe",
"distributed/pipeline/sync/skip/test_inspect_skip_layout",
"distributed/pipeline/sync/skip/test_leak",
"distributed/pipeline/sync/skip/test_portal",
"distributed/pipeline/sync/skip/test_stash_pop",
"distributed/pipeline/sync/skip/test_tracker",
"distributed/pipeline/sync/skip/test_verify_skippables",
"distributed/pipeline/sync/test_balance",
"distributed/pipeline/sync/test_bugs",
"distributed/pipeline/sync/test_checkpoint",
"distributed/pipeline/sync/test_copy",
"distributed/pipeline/sync/test_deferred_batch_norm",
"distributed/pipeline/sync/test_dependency",
"distributed/pipeline/sync/test_inplace",
"distributed/pipeline/sync/test_microbatch",
"distributed/pipeline/sync/test_phony",
"distributed/pipeline/sync/test_pipe",
"distributed/pipeline/sync/test_pipeline",
"distributed/pipeline/sync/test_stream",
"distributed/pipeline/sync/test_transparency",
"distributed/pipeline/sync/test_worker",
"distributed/rpc/cuda/test_tensorpipe_agent",
"distributed/rpc/test_tensorpipe_agent",
"distributed/test_c10d_common",
"distributed/test_c10d_gloo",
"distributed/test_c10d_nccl",
"distributed/test_c10d_spawn_gloo",
"distributed/test_c10d_spawn_nccl",
"distributed/test_distributed_spawn",
"distributed/test_jit_c10d",
"distributed/test_pg_wrapper",
"distributed/test_store",
"distributions/test_distributions",
# test_autograd.py is not slow, so it does not belong here. But
# note that if you try to add it back it will run into
# https://bugs.python.org/issue40350 because it imports files
Expand Down

0 comments on commit 9797a32

Please sign in to comment.