Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window end heuristic for hallucination_silence_threshold #2043

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryanheise
Copy link
Contributor

Removes the end-of-window heuristic mentioned in #1838 (comment) which was causing it to (too) opportunistically skip over the silence at the end of the window when sometimes it was not in fact silence.

Its removal unmasks the similar block directly above it which should work well enough in this case:

                if not single_timestamp_ending:
                    last_word_end = get_end(current_segments)
                    if last_word_end is not None and last_word_end > time_offset:
                        seek = round(last_word_end * FRAMES_PER_SECOND)

Purfview added a commit to Purfview/faster-whisper that referenced this pull request Feb 23, 2024
Removes the wishful heuristic causing more issues than it's fixing.

Same as openai/whisper#2043

Example of the issue: openai/whisper#1838 (comment)
nguyendc-systran pushed a commit to SYSTRAN/faster-whisper that referenced this pull request Feb 29, 2024
Removes the wishful heuristic causing more issues than it's fixing.

Same as openai/whisper#2043

Example of the issue: openai/whisper#1838 (comment)
linsen20220222 pushed a commit to zebra-media/whisper that referenced this pull request Nov 29, 2024
…#2043)

* make : add AVX512 detection to Makefile and CMakeLists.txt

* make : autodetect more AVX512 instruction subsets

* cmake : do not default to AVX512, must be enabled explicitly

* cmake : enable a set of AVX512 subsets, when AVX512 is turned on

* make : consolidate AVX512 subsets, add AVX512 VBMI

* cmake : revert to NO AVX512 setting, add settings for AVX512 VNNI and VBMI

* make : re-introduce AVX512VNNI back

* cmake : remove superfluous comment line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant