-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openalea namespace #122
base: master
Are you sure you want to change the base?
Conversation
@thomasarsouze : if you modify the namespace, you will have to change all the tests, the examples, and the doc also. |
@pradal : yes this is what I thought, but as mentioned yesterday, we're working first on packages that already have the namespace, which is not the case here. |
@thomasarsouze I think that this is a good idea to harmonize the way openalea packages are treated, although it makes things a bit verbose. |
Sorry for the late reply @RamiALBASHA. Indeed it is much safer to have a new release associated with this namespace change to prevent code break or at least make it easier to debug. As the hydroshoot package manager, I let you decide how to tag your version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests all pass ok. However, before merging, please be aware that at the moment, Caribu with corrected namespace has not been released on all OS / python versions (cf. here).
Issue is currently handled though: openalea-incubator/caribu#50
Ok, thanks @thomasarsouze. Is there any deadline for merging? I need to take my time on this issue. |
No rush... |
No description provided.