Fix karma-browserify prebundle #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM at a glance but not to travis |
aron
force-pushed
the
karma-prebundle
branch
from
6c9b71b
to
e984345
Compare
|
I think it was just Travis being kranky. |
As described in the GitHub issue. We now have to include "annotator" explicitly as the "expose" parameter seems to break doing a relative include for the same module.
nickstenning
force-pushed
the
karma-prebundle
branch
from
e984345
to
f18d686
Compare
|
LGTM. It's unfortunate that we have to do |
nickstenning
added a commit
that referenced
this pull request
Dec 12, 2014
Fix karma-browserify prebundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now call the
bundle.require('./src/annotator', {expose: 'annotator'})each time the bundle is reset. This fixed the bundling issue and introduced a second problem, that require('./src/annotator') fails after the expose alias has been set. So to fix this I've just ensured all testsrequire('annotator').