feat: Add two generation config flags to raise exceptions #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We know the type of this: It's `None`, so we don't need to annotate it as `Any`.
cast(None, None) made mypy fail after that last commit.
It makes sense to return the parsed JSON here instead of None.
This was introduced in "fix: Make empty response a `NoneProperty`", but is easier to fix now since parsed_responses in endpoint_module.py.jinja does not include `Any` response types anymore.
robertschweizer
force-pushed
the
add-generation-flags-to-raise-exceptions
branch
from
737869a to
41d739c
Compare
Also prevents double return type annotations like `Optional[None]`.
raise_on_error_status raises a `httpx.HTTPStatusError` on all error response codes without decoding. raise_on_unexpected_status is identical to the existing `Client.raise_on_unexpected_status` runtime setting, but leads to better return type annotations.
robertschweizer
force-pushed
the
add-generation-flags-to-raise-exceptions
branch
from
41d739c to
4e213e6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
===========================================
- Coverage 100.00% 99.89% -0.11%
===========================================
Files 49 49
Lines 1978 1993 +15
===========================================
+ Hits 1978 1991 +13
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raise_on_error_statusraises ahttpx.HTTPStatusErroron all errorresponse codes without decoding. This can later be improved to add an exception that includes the decoded content, or to even raise different exception types for each response code (see #736 (comment)).
raise_on_unexpected_statusis identical to the existingClient.raise_on_unexpected_statusruntime setting, but leads to betterreturn type annotations.
Closes #491
This is a rework of #736, with the main intention of reducing the generated
syncandasynciofunctions' return type annotations to documented successful responses.Includes the commits from #742, which should be merged first.