Skip to content

refactor(knowledge-network): drop run_sql, list_resources and describe_resource from the Context Loader console - #1320

Merged
sh00tg0a1 merged 1 commit into
mainfrom
refactor/remove-run-sql
Nov 11, 2026
Merged

sh00tg0a1 merged 1 commit into
mainfrom
refactor/remove-run-sql

Conversation

@sh00tg0a1

Copy link
Copy Markdown
Member

Pull Request

What Changed

  • Context Loader console (context-loader.service.ts): the run_sql, list_resources and describe_resource ops removed, with their test-data builders, the resource data-assistant kind and the run_sql branch of requestDataAssistantKindOf.
  • ExperienceScene / DataBrowserPanel / ContextLoaderIntegrationPanel: the data-resource row, the "fill {{resource}} into SQL" helper and their styles removed.
  • Locales (context-loader-panel, both languages): 11 keys used only by the removed UI deleted; agent-chat truncation notes no longer name run_sql.
  • Tests updated; opSupportsTestData("run_sql") now asserted false.

Why


How

  • Key implementation points:
    • Removed everything that lets a user pick, try or fill these tools.
    • Kept everything that only displays them: tool display names and grouping in mcp-tool-display.ts, toolNames in the context-loader-panel locales, the bkn-trace business-provenance tool list, titles and the runSql label. Old chat transcripts and traces still contain these names and must keep rendering. The data / resource group descriptions stay for the same reason.
  • Breaking changes (API, config, database, etc.): none in Studio's own API; the console no longer lists three ops the backend no longer serves.

Testing

  • Unit tests passed locally
  • Integration tests passed locally — N/A for this change
  • Verified in test environment — not hand-tested in a running console

Test notes:

  • pnpm exec tsc -b --pretty false: clean.
  • pnpm exec eslint . --config eslint.config.typechecked.js --max-warnings 0: clean; format:check and license-header check clean.
  • pnpm exec vitest --run src/modules/knowledge-network src/modules/bkn-trace src/app/locales: 338 files, 3098 tests passed (incl. locale parity). Full suite left to CI per AGENTS.md.

Risk & Rollback

  • Potential risks: low; the removed ops already returned 404. No UI-level assertion was added that the three are gone from the op list.
  • Rollback plan: revert this PR.

Additional Notes

  • Remaining mentions in tests use run_sql only as a historical tool name; QuickAddApiForm.test.ts uses the old URL as an arbitrary sample API.

🤖 Generated with Claude Code

…e_resource from the Context Loader console

Context Loader removed these three tools (REST routes now 404, MCP stopped
offering them earlier). Remove the curated ops, test-data fill, the
SQL resource-placeholder data assistant and its locale strings. Display
labels for historical traces and chat transcripts are kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sh00tg0a1 sh00tg0a1 added the by-agent Issue or pull request produced by an agent label Nov 11, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除 run_sql / list_resources / describe_resource 及 resource 数据助手的改动干净:knowledge-network 内无残留调用、被删 i18n key 在 zh/en 两份同步移除且无剩余引用,选中 op 失效时 ExperienceScene 已有回退到首个 op 的 effect。未发现阻塞项。

有异议或想再评一轮,请回复 /review——普通回帖不会触发复评,且回帖人需为本仓 OWNER/MEMBER/COLLABORATOR。

@sh00tg0a1
sh00tg0a1 merged commit 7febda1 into main Nov 11, 2026
34 of 36 checks passed
@sh00tg0a1
sh00tg0a1 deleted the refactor/remove-run-sql branch November 11, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

by-agent Issue or pull request produced by an agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant