Repository navigation
refactor(knowledge-network): drop run_sql, list_resources and describe_resource from the Context Loader console - #1320
Merged
Merged
Conversation
…e_resource from the Context Loader console Context Loader removed these three tools (REST routes now 404, MCP stopped offering them earlier). Remove the curated ops, test-data fill, the SQL resource-placeholder data assistant and its locale strings. Display labels for historical traces and chat transcripts are kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What Changed
context-loader.service.ts): therun_sql,list_resourcesanddescribe_resourceops removed, with their test-data builders, theresourcedata-assistant kind and therun_sqlbranch ofrequestDataAssistantKindOf.ExperienceScene/DataBrowserPanel/ContextLoaderIntegrationPanel: the data-resource row, the "fill{{resource}}into SQL" helper and their styles removed.context-loader-panel, both languages): 11 keys used only by the removed UI deleted;agent-chattruncation notes no longer namerun_sql.opSupportsTestData("run_sql")now asserted false.Why
run_sql,list_resourcesordescribe_resourceHow
mcp-tool-display.ts,toolNamesin thecontext-loader-panellocales, the bkn-trace business-provenance tool list, titles and therunSqllabel. Old chat transcripts and traces still contain these names and must keep rendering. Thedata/resourcegroup descriptions stay for the same reason.Testing
Test notes:
pnpm exec tsc -b --pretty false: clean.pnpm exec eslint . --config eslint.config.typechecked.js --max-warnings 0: clean;format:checkand license-header check clean.pnpm exec vitest --run src/modules/knowledge-network src/modules/bkn-trace src/app/locales: 338 files, 3098 tests passed (incl. locale parity). Full suite left to CI per AGENTS.md.Risk & Rollback
Additional Notes
run_sqlonly as a historical tool name;QuickAddApiForm.test.tsuses the old URL as an arbitrary sample API.🤖 Generated with Claude Code