Repository navigation
fix(knowledge-network): preserve relation picker search after LIKE alignment - #1322
Open
rongwei-liu wants to merge 1 commit into
Open
rongwei-liu wants to merge 1 commit into
rongwei-liu wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
改动把关系实例选择器的文本检索改为 %<转义后关键词>% 的完整 SQL LIKE 模式,并补上了 _ 的转义,转义规则与仓内 data-catalog 的 sqlLikePatternRegex 约定一致;新增测试断言了真实请求体,未发现阻断问题。
影响范围与未覆盖面
- 影响范围:仅影响评测用例表单中关系实例选择器的模糊搜索;若 Studio 先于 Foundry 的 LIKE 契约改动上线,旧后端对显式
%的处理方式会决定搜索结果是否正确。 - 未覆盖:后端
/agent-retrieval/v1/kn/query_object_instance的 LIKE 转义语义在 Foundry 仓库,本轮未核实。
有异议或想再评一轮,请回复 /review——普通回帖不会触发复评,且回帖人需为本仓 OWNER/MEMBER/COLLABORATOR。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What Changed
Brief description of changes:
%,_, and backslash as literal characters.Why
How
%before sending the existing object-instance query. Numeric primary-key searches and structured identity searches retain their existing exact-match paths.Testing
Test notes:
pnpm exec vitest --run --maxWorkers=50% src/modules/knowledge-network/eval/case-form.service.test.ts(13 passed); repository formatter, license check, format check, type-aware ESLint,tsc -b, production Vite build, andpnpm audit --prodpassed. The build emits existing dependency annotation and chunk-size warnings.Risk & Rollback
Additional Notes